feat(@angular/cli): add flag to control chunk naming - #7007
Merged
Conversation
hansl
previously approved these changes
Jul 17, 2017
| - *service*: Options for generating a service. | ||
| - *flat* (`boolean`): Flag to indicate if a dir is created. Default is `true`. | ||
| - *spec* (`boolean`): Specifies if a spec file is generated. Default is `true`. | ||
| - *build*: Properties to be passed to the serve command |
Contributor
There was a problem hiding this comment.
typo:
Properties to be passed to the serve build command
| - *build*: Properties to be passed to the serve command | ||
| - *sourcemaps* (`boolean`): Output sourcemaps. | ||
| - *baseHref* (`string`): Base url for the application being built. | ||
| - *progress* (`boolean`): The ssl key used by the server. Default is `true`. |
filipesilva
force-pushed
the
named-chunks-flag
branch
from
July 18, 2017 12:49
1e9d562 to
b3557ed
Compare
Contributor
Author
|
Good catches @antonybudianto, thanks! |
filipesilva
force-pushed
the
named-chunks-flag
branch
from
July 18, 2017 20:07
b3557ed to
ac5eceb
Compare
1 task
filipesilva
force-pushed
the
named-chunks-flag
branch
from
July 19, 2017 14:24
ac5eceb to
df5209b
Compare
Brocco
suggested changes
Jul 19, 2017
| <details> | ||
| <summary>named-chunks</summary> | ||
| <p> | ||
| <code>--named-chunks</code> (aliases: <code>-scd</code>) |
Contributor
There was a problem hiding this comment.
The alias scd does not match the one in code nc.
filipesilva
force-pushed
the
named-chunks-flag
branch
2 times, most recently
from
July 19, 2017 15:37
a8ac917 to
ceeddfe
Compare
Followup to angular#6881 Allow controlling chunk naming via the `--named-chunks` flag, which can be set on `.angular-cli.json` as well. Defaults to true in development, false in production.
filipesilva
force-pushed
the
named-chunks-flag
branch
from
July 19, 2017 16:31
ceeddfe to
0e8c35c
Compare
Brocco
approved these changes
Jul 19, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6881
Allow controlling chunk naming via the
--named-chunksflag, which can be set on.angular-cli.jsonas well.Defaults to true in development, false in production.
Fix #6999